feat: UdpSocket/UdpStream - #150
Merged
Merged
Conversation
ryan-surname-p
force-pushed
the
rnpridgeon-p2-udp
branch
from
September 4, 2026 17:29
bd92700 to
9628bc5
Compare
ryan-surname-p
force-pushed
the
rnpridgeon-p2-udp
branch
from
September 4, 2026 17:37
9628bc5 to
fcb4472
Compare
ryan-surname-p
commented
Sep 4, 2026
| } | ||
| } | ||
|
|
||
| fn sockaddr_from_wasi(addr: IpSocketAddress) -> std::net::SocketAddr { |
Contributor
Author
There was a problem hiding this comment.
lifted from net/tcp_listern.rs
| } | ||
| } | ||
|
|
||
| fn sockaddr_from_wasi(addr: IpSocketAddress) -> std::net::SocketAddr { |
Contributor
Author
There was a problem hiding this comment.
lifted to net/mod.rs
ryan-surname-p
commented
Sep 4, 2026
| Ok(()) | ||
| } | ||
|
|
||
| fn get_listening_address( |
Contributor
Author
There was a problem hiding this comment.
lifted into lib.rs
| /// | ||
| /// Guest programs which bind a socket print `Listening on {addr}`, so that a | ||
| /// test can discover the address even when the guest picked the port. | ||
| pub fn get_listening_address( |
Contributor
Author
There was a problem hiding this comment.
lifted from tests/tcp_echo_server.rs
ryan-surname-p
marked this pull request as ready for review
September 4, 2026 17:40
pchickey
approved these changes
Sep 8, 2026
Contributor
|
Thanks, Ryan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #95